Closed mjameswh closed 5 days ago
How this was tested
Feel free to add those tests explicitly if it would help (though I only mean the tests for properly enabled IPv4/IPv6, obviously won't work for use cases where you want to test no-IPv6 loopback)
What was changed
--ip 0.0.0.0
on machines that have IPv6 support but isn't fully configured (e.g. doesn't have a loopback interface bound to::1
). Fix #595.--ip ::1
or--ui-ip ::
).--ui-ip
and--ui-port
. Fix #602.ip:port
is already in use. Fix #242.--ip 127.0.0.2
).How this was tested
I added a few integration tests.
However, most cases fixed in this PR relates to specific network configuration, which can't easily be reproduced in CI or on developer machines. These changes were therefore only validated by manual testing.
For future reference, this is the gist of what I did on my Mac.
To test in Docker, I had to use Rancher Desktop, with Kubernetes support enabled. The important thing for testing #595 is that the kernel of the virtual machine used by Docker must be compiled with IPv6 support (e.g.
/proc/sys/net/ipv6
exists), but the container image must not be configured for IPv6 (e.g.ip addr show dev lo
doesn't show any IPv6 address, andping6 ::1
fails). The VM used by Docker Desktop won't work, apparently because it configures container's IPv6 correctly.