search

temporalio / docker-builds

Temporal service Docker images build
https://hub.docker.com/r/temporaliotest/auto-setup
MIT License
30 stars 59 forks source link

Cache docker builder cache between runs #161

Closed tdeebswihart closed 1 year ago

tdeebswihart commented 1 year ago

What was changed

This preserves docker buildkit cache mounts between runs by integrating with GHA's caching. While I was here I bumped the version of all the GHAs we use

Why?

This should improve the performance of our build pipelines and hopefully keep them from timing out rebuilding things we've built many times before.

tdeebswihart commented 1 year ago

NOTE: this may not work with https://depot.dev which we're investigating (and they even feature us as an example 😣), so I'm going to hold off on this in favor of https://github.com/temporalio/docker-builds/pull/163 which is also supported by depot

tdeebswihart commented 1 year ago

It does work with depot, I reread the docs. This would still be useful.

I’ll test local builds in a bit

tdeebswihart commented 1 year ago

This now depends on https://github.com/temporalio/docker-builds/pull/164

tdeebswihart commented 1 year ago

The manual cache management workaround is courtesy of https://github.com/moby/buildkit/issues/4262