search

temporalio / docker-builds

Temporal service Docker images build
https://hub.docker.com/r/temporaliotest/auto-setup
MIT License
30 stars 59 forks source link

Use the released CLI artifacts #204

Open tdeebswihart opened 6 months ago

tdeebswihart commented 6 months ago

What was changed

We use the pre-built CLI artifacts from the official releases rather than compiling them ourselves

Why?

Calculating the CLI's version based on the tag is a pain (see https://github.com/temporalio/docker-builds/pull/203) and I don't want to do that in our Makefile, so we're going to download the appropriate artifact from the official release instead

Note

This is gross but it works. I'm putting this up to stimulate discussion on how we should do it.

tdeebswihart commented 6 months ago

The version can be bumped automatically using sed:

$ sed -i '' 's/^CLI_VER.*/CLI_VER := v0.13.0/' Makefile
robholland commented 5 months ago

This should also fix https://github.com/temporalio/docker-builds/issues/107

robholland commented 5 months ago

Also makes progress on #43

robholland commented 5 months ago

Re-thinking this, I think we should build for temporaliotest and releases differently. Release builds should use released assets rather than building (action can prompt for the various release numbers). Test builds should just use whatever the submodules are at. We don't have the complex docker tags for test builds, so we don't have to calculate any tags.