search

temporalio / docker-builds

Temporal service Docker images build
https://hub.docker.com/r/temporaliotest/auto-setup
MIT License
30 stars 59 forks source link

Ensure binaries are rebuilt when target changes. #208

Closed robholland closed 5 months ago

robholland commented 5 months ago

What was changed

Clean binaries before compiling.

Why?

Changing the OS/arch does not cause make to recompile binaries. This meant whichever arch was compiled first would then be used in place of all the others. Cleaning the binaries before compiling ensures we build for the correct arch.

Checklist

  1. Closes #194

  2. How was this tested:

    Tested using file build/amd64/* and file build/arm64/* before and after the fix to ensure the binaries were for the correct architecture.

  3. Any docs updates needed?