temporalio / docker-builds

Temporal service Docker images build
https://hub.docker.com/r/temporaliotest/auto-setup
MIT License
30 stars 59 forks source link

Don't ignore fatal errors from auto-setup.sh #209

Closed robholland closed 5 months ago

robholland commented 5 months ago

What was changed

Don't continue to start the Temporal Server if auto-setup.sh returns an error. Improved the database driver validation error message.

Why?

Starting the server when auto-setup.sh found an error obscures the error message from auto-setup.sh, making it harder for users to understand what is wrong. Also try to make it clearer that DB= sets the driver type, and report the valid values.

Checklist

  1. Closes

  2. How was this tested:

    Used the modified image to start badly configured containers and check the error reporting is clearer.

  3. Any docs updates needed?