temporalio / docker-builds

Temporal service Docker images build
https://hub.docker.com/r/temporaliotest/auto-setup
MIT License
30 stars 59 forks source link

Default broadcast address to primary IP if binding on all interfaces #216

Closed robholland closed 5 months ago

robholland commented 5 months ago

What was changed

Set a sensible default for broadcast address if BIND_ON_IP is 0.0.0.0.

Why?

We require broadcast address to be set if listening on all interfaces, but it is not possible for users to know which IP they will have via environment variables on all platforms.

Checklist

  1. Closes

  2. How was this tested: Tested by two users on slack replacing their custom docker images that set TEMPORAL_BROADCAST_ADDRESS for them. Also note this only sets TEMPORAL_BROADCAST_ADDRESS if it isn't already set and BIND_ON_IP=0.0.0.0 which is a known broken configuration anyway.

  1. Any docs updates needed?