temporalio / docker-builds

Temporal service Docker images build
https://hub.docker.com/r/temporaliotest/auto-setup
MIT License
29 stars 57 forks source link

[Bug] admin tools image: Missing server-versioned docker tag for 1.24.x #222

Open chlunde opened 2 months ago

chlunde commented 2 months ago

What are you really trying to do?

We're trying to easily use a compatible version of the temporal CLI for a given version of the temporal cluster (via temporal-operator).

Describe the bug

repo status
temporalio/server:1.23.0 :1st_place_medal:
temporalio/server:1.23.1 :1st_place_medal:
temporalio/server:1.24.2 :1st_place_medal:
temporalio/admin-tools:1.23.0 :1st_place_medal:
temporalio/admin-tools:1.23.1 :1st_place_medal:
temporalio/admin-tools:1.24.0 :x:
temporalio/admin-tools:1.24.2 :x:

It seems 1.24.x uses a new tagging strategy (temporalio/admin-tools:1.24.2-tctl-1.18.1-cli-0.13.0), but it would be very helpful if there also existed a tag for a "compatible CLI tool for that version of temporal" using the server tag only.

Minimal Reproduction

docker pull temporalio/admin-tools:1.24.2

Environment/Versions

zaenk commented 1 month ago

this feels really sub-optimal right now - for a docker compose file three different versions need to be set up - one for the admin-tools, another for server or auto-setup and a third one for ui

jmcnevin commented 22 hours ago

Agreed. The current tagging strategy for the admin-tools container is... a lot. It would be nice to have at least one of these images tagged as a default for a particular Temporal version. I'm just trying to run some database migrations with it, so I don't really care about the CLI version.