temporalio / docker-compose

Temporal docker-compose files
MIT License
308 stars 202 forks source link

Update Dockerfile.admin-tools-tls #174

Closed ghost closed 5 months ago

ghost commented 1 year ago

Solving permission error while running update-ca-certificates (see https://community.temporal.io/t/docker-compose-tls-installation-failed/7895)

What was changed

A single line was added to solve the following error while running bash ./tls/run-tls.sh following the tls setup README.md:

 => ERROR [temporal-admin-tools 3/3] RUN update-ca-certificates                                                                                                                                                  0.2s
------
 > [temporal-admin-tools 3/3] RUN update-ca-certificates:
#0 0.203 Failed to open temporary file /etc/ssl/certs/bundleXXXXXX for ca bundle
------
failed to solve: process "/bin/bash -c update-ca-certificates" did not complete successfully: exit code: 1

Why?

By adding the line USER root, docker is able to successfully execute the update-ca-certificates command located in the changed file.

Checklist

  1. How was this tested: Built and executed on Ubuntu 22.04 according to the README.md.

  2. Any docs updates needed? Not to my knowledge.

ghost commented 1 year ago

Review on Crocodile

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

cdimitroulas commented 8 months ago

Any chance we could get this merged? This error prevents running the ./tls/run-tls.sh script for all users at the moment :)