search

temporalio / documentation

Temporal documentation
https://docs.temporal.io
Other
84 stars 218 forks source link

Golang scheduler deletion example: Remove unnecessary error check for GetHandle() #2978

Closed ulascansenturk closed 2 weeks ago

ulascansenturk commented 1 month ago

What does this PR do?

Error handling for GetHandle(): The original code checks for an error after calling GetHandle(), but GetHandle() doesn't return an error. This check was unnecessary and has been removed.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

ulascansenturk commented 3 weeks ago

Hello @jsundai i am authorizing the deployment on vercel but it doesn't do anything, and CI is failing because of that.

jsundai commented 3 weeks ago

Hello @jsundai i am authorizing the deployment on vercel but it doesn't do anything, and CI is failing because of that.

@ulascansenturk Thanks for the contribution! Authorizing deployment on Vercel is for internal folks but we'll make sure to review this PR in this sprint.