Open mastermanu opened 2 years ago
We would also like this.
As suggested on the Temporal Slack channel, I used this metric instead:
temporal_request{operation="StartWorkflowExecution"}
As suggested on the Temporal Slack channel, I used this metric instead:
temporal_request{operation="StartWorkflowExecution"}
Just wanted to clarify for folks without the full context. temporal_request{operation="StartWorkflowExecution"}
is really just an approximation to what this issue is requesting - workflow_started
. The temporal_request
metric only track the attempts made by the client, instead of the actual Workflow execution from the worker side. For example, if we there are no workers running, no matter how many time we request StartWorkflowExecution, no Workflow would actually start.
I'd still recommend folks to upvote this issue if you do need the worker side metric.
I'm not really sure this should be an sdk metric as execution is created on service side if workers are around or not. Would add to service metrics https://github.com/temporalio/temporal/blob/main/common/metrics/metric_defs.go#L884-L889 instead
Has value in both places. This specific request is to track specific-worker workflow starts, not to be used as a general workflow started metric. But I agree in general it has very limited value and anyone could add themselves with an interceptor.
wf_completed, wf_continue_as_new exists, but there is no corresponding wf_started metric.