[Feature Request] Configurable workflow failure exception types

[cretz]

Describe the solution you'd like

We need to let users choose what fails the workflow vs what just fails the task today. Go and Java already have some form of this. To do:

• Go - https://github.com/temporalio/sdk-go/issues/1387
  • [x] Worker task failure - WorkflowPanicPolicy exists (panics are the only task failures today)
  • [ ] Workflow task failure - Need workflow.RegisterOptions.WorkflowPanicPolicy (or do we?)
• Java - https://github.com/temporalio/sdk-java/issues/1987
  • [ ] Worker task failure - Need WorkerOptions.Builder.setFailWorkflowExceptionTypes​(...Throwable) (or do we?)
  • [x] Workflow task failure - WorkflowImplementationOptions.Builder.setFailWorkflowExceptionTypes​(...Throwable) exists
• Core - https://github.com/temporalio/sdk-core/issues/656
  • [x] Worker task failure - Need WorkerConfig.workflow_failure_errors: HashSet<WorkflowTaskFailureType> (only value for WorkflowTaskFailureType today is Nondeterminism)
  • [x] Workflow task failure - Need WorkerConfig.workflow_failure_errors_by_workflow_type: HashMap<String, HashSet<WorkflowTaskFailureType>>
• TS - https://github.com/temporalio/sdk-typescript/issues/1358
  • [ ] Worker/workflow task failure - Need WorkerOptions.workflowFailureErrorTypes: Record<string|'*', Array<Error>>
  • Note, if type set contains DeterminismViolationError then core side should be set
• Python - https://github.com/temporalio/sdk-python/issues/446
  • [x] Worker task failure - Need workflow_failure_exception_types: Set[Type[Exception]] on Worker constructor
  • [x] Workflow task failure - Need failure_exception_types: Set[Type[Exception]] on @workflow.defn decorator
  • Note, if type set contains NondeterminismError then core side should be set
• .NET - https://github.com/temporalio/sdk-dotnet/issues/166
  • [x] Worker task failure - Need IReadOnlyCollection<Type> WorkflowFailureExceptionTypes on TemporalWorkerOptions
  • [x] Workflow task failure - Need Type[] FailureExceptionTypes on WorkflowAttribute and IReadOnlyCollection<Type> FailureExceptionTypes on WorkflowDefinition
  • Note, if type set contains InvalidWorkflowOperationException then core side should be set

This can change at implementation time, this is just a guide.

[cretz]

Discussion is occurring on potentially changing default from task fail to workflow fail, so we probably need to make that option a simple on/off bool in addition to the configurable exception types (instead of just using Exception type as the way to opt-in to all).

Also, we may need to make sure that deadlocks aren't allowed to fail workflows and therefore aren't subject to this. May need more discussion.

[cretz]

Note for implementers on core-based SDKs, it may be reasonable to have a non-determinism exception that's only used in the replayer, but that is the "marker" type for telling core that you want non-determinism failures as wf failures instead of task failures.

[cretz]

Also more note for SDK implementers:

• We want to mark this as experimental at first until it's in all SDKs and we're happy with it.
• For update handlers, they should apply the failure types to fail an update except (even though it's called "workflow failure exception types"):
  • Non-determinism should still apply at a workflow level
  • Read-only violation of handler is still a task failure