search

temporalio / features

Behavior and history compatibility testing for Temporal SDKs
13 stars 15 forks source link

[Feature Request] Worker tracing should upsert header with outer span #394

Open cretz opened 7 months ago

cretz commented 7 months ago

Describe the solution you'd like

When the tracing interceptor is in use, by default creating a schedule should create a span for the schedule and set it on the workflow header if the action is starting a workflow. Users need to be able to opt-out in their tracing interceptor options.

cretz commented 6 months ago

We may prefer a different approach here where we instead create a span per workflow when the workflow is first run. We probably don't want a span for the entirety of the schedule, just need an overarching span for the workflow. Still discussing...

cretz commented 5 months ago

After discussion, there is just no place for an interceptor in all SDKs to persist durable data. Only some SDKs have side effect, and can't use local activity in others because they must be registered, and "upsert header" has a lookahead problem since we can't mutate the header, only mark that we have updated it within history.