Open cretz opened 6 months ago
Ok, we're fairly sure we want to combine concepts here. Here are some requirements:
Today we already have temporal env
, so we may be able to reuse that, but there are some problems:
These need to be solved.
Agree that it would be great to reuse the CLI env file and unify that experience.
This is YAML and adding YAML libraries to our SDKs has knock-on effects for users
Maybe we should just switch to JSON as we don't expect most users to be editing this file manually. That would remove the YAML lib dependency.
The use of the term "env" for config file with "env name" and "setting name" instead of something like "config" and "profile" is confusing
Agree, profile might be less confusing but I'm not sure we want to change the terminology for CLI users that already use the feature although now might be the perfect time to make this change since we're redesigning the env
command API.
Initial proposal now available at https://github.com/temporalio/proposals/pull/94
Describe the solution you'd like
Will add more as more is discussed. Notes:
NewClientOptionsFromEnvironment()
instead of just assuming when unset to pull from envEDIT: Initial proposal now available at https://github.com/temporalio/proposals/pull/94