SDKs should default set gRPC max receive message size to 128MB

temporalio / features

Behavior and history compatibility testing for Temporal SDKs

13 stars 17 forks source link

SDKs should default set gRPC max receive message size to 128MB #46

Open bergundy opened 2 years ago

bergundy commented 2 years ago

SDK checklist

[x] Java
[x] Go - https://github.com/temporalio/sdk-go/issues/794
[ ] Core
[ ] TS
[ ] .NET

Add a test that confirms this in sdk-feature repo

josh-berry commented 1 year ago

Do we actually want to do this? 128MiB seems extremely large and I'd start to worry about fairness issues between workflows/activities in the same worker.

bergundy commented 1 year ago

I must admit that I have no recollection of why we did this, but it’s the behavior in both Go and Java now.

cretz commented 1 year ago

I think we just matched Java. It will get rejected by server-side limits anyways usually, but that is exposed as a config and this is not so it's set high enough not to be hit hopefully I guess.

cretz commented 1 year ago

To fix my statement above, server limit only applies to requests I think, but server response (e.g. a large page of history) can be large.