Open Spikhalskiy opened 2 years ago
Align the behavior of activity heartbeat throttling on all SDKs.
Internal Temporal design doc: https://www.notion.so/temporalio/Activity-heartbeats-inconsistent-behavior-between-SDKs-32d81da0748044a8932481d2c9864791 Exported: Activity_heartbeats_inconsistent_behavior_between_SDKs.pdf
Add 2 new WorkerOptions:
WorkerOption
maxHeartbeatThrottleInterval
defaultHeartbeatThrottleInterval
throttleInterval = min(heartbeat_timeout * 0.8 if heartbeat_timeout is provided, else defaultHeartbeatThrottleInterval, maxHeartbeatThrottleInterval)
throttleInterval
min
heartbeat_timeout * 0.8
heartbeat_timeout
https://github.com/temporalio/sdk-go/issues/656 https://github.com/temporalio/sdk-java/issues/906
This was already implemented in all SDKs. Leaving it open to add a feature in this repo.
Align the behavior of activity heartbeat throttling on all SDKs.
Internal Temporal design doc: https://www.notion.so/temporalio/Activity-heartbeats-inconsistent-behavior-between-SDKs-32d81da0748044a8932481d2c9864791 Exported: Activity_heartbeats_inconsistent_behavior_between_SDKs.pdf
Design
Add 2 new
WorkerOption
s:maxHeartbeatThrottleInterval
- default 60sdefaultHeartbeatThrottleInterval
- default 30sthrottleInterval
=min
(heartbeat_timeout * 0.8
ifheartbeat_timeout
is provided, elsedefaultHeartbeatThrottleInterval
,maxHeartbeatThrottleInterval
)Rationale
Tasks
https://github.com/temporalio/sdk-go/issues/656 https://github.com/temporalio/sdk-java/issues/906