temporalio / features

Behavior and history compatibility testing for Temporal SDKs
13 stars 16 forks source link

✅ Activity Heartbeat Throttling #67

Open Spikhalskiy opened 2 years ago

Spikhalskiy commented 2 years ago

Align the behavior of activity heartbeat throttling on all SDKs.

Internal Temporal design doc: https://www.notion.so/temporalio/Activity-heartbeats-inconsistent-behavior-between-SDKs-32d81da0748044a8932481d2c9864791 Exported: Activity_heartbeats_inconsistent_behavior_between_SDKs.pdf

Design

Add 2 new WorkerOptions:

throttleInterval = min(heartbeat_timeout * 0.8 if heartbeat_timeout is provided, else defaultHeartbeatThrottleInterval, maxHeartbeatThrottleInterval)

Rationale

Tasks

https://github.com/temporalio/sdk-go/issues/656 https://github.com/temporalio/sdk-java/issues/906

bergundy commented 2 years ago

This was already implemented in all SDKs. Leaving it open to add a feature in this repo.