temporalio / helm-charts

Temporal Helm charts
MIT License
321 stars 343 forks source link

[Feature Request] Enable LivenessProbe for workers #298

Closed gracco closed 5 months ago

gracco commented 2 years ago

Is your feature request related to a problem? Please describe.

When we deploy a new cluster, the workers nodes don't have a LivenessProbe because it's explicit configured in the code to not add them.

Describe the solution you'd like

Remove the if loop in the lines above. Or implement a specific livenessProbe for workers.

https://github.com/temporalio/helm-charts/blob/master/templates/server-deployment.yaml#L127-L132

{{- if ne $service "worker"}}
          livenessProbe:
             initialDelaySeconds: 150
             tcpSocket:
               port: rpc
 {{- end }}

Additional context

robholland commented 5 months ago

Workers don't have a listener to probe.