temporalio / helm-charts

Temporal Helm charts
MIT License
299 stars 329 forks source link

[Feature Request] Being able to configure the web UI #369

Closed Smana closed 1 year ago

Smana commented 1 year ago

Being able to configure the web UI. Indeed currently the Helm chart supports the creation of a configmap here. Unfortunately, this configmap is never used under the web deployment.

Actually what I want to do is to configure the OICD auth. I found a thread in slack that mention another way than using the configmap: by setting environment variables as follows in the Web deployment:

- name: TEMPORAL_AUTH_ENABLED
  value: "true"
- name: TEMPORAL_AUTH_CALLBACK_URL
  value: "https://temporal-dev.xyz.com/"
- name: TEMPORAL_AUTH_PROVIDER_URL
  value: "https://login.microsoftonline.com/XYZ/v2.0"
- name: TEMPORAL_AUTH_LABEL
  value: "azure oidc"
- name: TEMPORAL_AUTH_TYPE
  value: "oidc"
- name: TEMPORAL_AUTH_CLIENT_ID
  value: "XYZ"
- name: TEMPORAL_AUTH_CLIENT_SECRET
  value: "XYZ"
- name: TEMPORAL_AUTH_SCOPES
  value: "openid profile email"

This works but declaring environment variables is not supported yet in the Helm chart. Then I noticed this PR but it is not merged since December.

So what is the recommended way of configuring the Web UI please? Are you considering merging the above PR or a solution to make use of the configmap?

jamessthompson commented 1 year ago

I'm looking for the same functionality. @Smana Did you mean #341 for the related PR? 340 looks like it's removing stuff.

underrun commented 1 year ago

this should be closed by https://github.com/temporalio/helm-charts/pull/341 having been merged - please feel free to re-open if there are issues.