search

temporalio / helm-charts

Temporal Helm charts
MIT License
312 stars 339 forks source link

prometheus metrics configuration seems to be broken since temporal 1.6.x #375

Closed kkcmadhu closed 1 year ago

kkcmadhu commented 1 year ago

https://github.com/temporalio/helm-charts/blob/cea9204c4ddcf2c60b23bc5a0eace487656385e1/templates/server-deployment.yaml#L39-L41 still uses per service metric config, which is deprecated as of temporal 1.1.x s replaced by global metric config.

I guess after 1.6 onwards the prometeus has stopped working and this needs an urgent attention.

Also refer these community discusisons

https://community.temporal.io/t/metrics-endpoint-not-being-enabled-on-upgrade/5247/5

https://community.temporal.io/t/prometheus-metrics-configuration-confusion/6592/6

kkcmadhu commented 1 year ago

seems my helm charts were not in sync and littled dated, updating the helm chart helped. sorry for the confusion closing this ticket.