temporalio / helm-charts

Temporal Helm charts
MIT License
294 stars 321 forks source link

feat: add conditional elasticsearch auth in curl commands #390

Closed alizdavoodi closed 1 year ago

alizdavoodi commented 1 year ago

What was changed

This PR updates the helm chart to conditionally include the Elasticsearch username and password in the command for the check-elasticsearch, check-elasticsearch-index, and create-elasticsearch-index containers.

Why?

These changes were made to allow the helm chart to be used in situations where the Elasticsearch instance does not require authentication. For example Opensearch is in a private network and doesn't have fine-grained auth in place. (If we pass any arbitrary/default username and password we will get 403)

Checklist

  1. How was this tested: test these changes by deploying the helm chart to a Kubernetes cluster with an Elasticsearch instance that does not require authentication, to ensure that the commands run successfully without the --user flag. Additionally, tested by deploying to a cluster with an Elasticsearch instance that does require authentication, to verify that the --user flag is properly included when needed.
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.