Closed washanhanzi closed 2 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
+1, spent ~hour trying to understand why OID does not work when finally found that config map is not mounted to any volume/file.
Can we get this merged? Also just spent a ton of time on auth that wasn't necessary.
@tsurdilo
I can't understand why this was not merged; we all suffered when we tried to change the web values, and nothing was affected!
@robholland
All done. By the way, is there any test I can run? The PR has been open for a really long time, and I haven't touched the temporal charts since then. I'm not as confident as I was when I submitted the PR.
Nothing automated. We internally use the helm charts to install the base app, but we don't modify the UI so wouldn't pick up on problems. I'll do a manual test before I merge it though.
What was changed
Why?
393
Checklist
Closes #393
How was this tested: manually, 100% craft by hand. since the repo didn't provide any testing tool.
Any docs updates needed? already updated with the PR.