temporalio / helm-charts

Temporal Helm charts
MIT License
294 stars 321 forks source link

FIX Add name value to pdb template #395

Closed rossvent closed 1 year ago

rossvent commented 1 year ago

What was changed

Why?

PodDisruptionBudget resources require a name field to be present, when utilizing pdb templates, helm upgrade throws the following error.

Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: could not get information about the resource: resource name may not be empty

When running helm template . --name-template temporal --values values.yaml --dry-run with PDB configured the generated resource does not contain a value for name: and when manually apply the resource (kubectl apply -f pdb.yaml) k8s server throws the following error

error: error when retrieving current configuration of:
Resource: "policy/v1, Resource=poddisruptionbudgets", GroupVersionKind: "policy/v1, Kind=PodDisruptionBudget"
Name: "", Namespace: "temporal"
from server for: "pdb.yaml": resource name may not be empty

After adding value to name PDBs are created successfully

Checklist

  1. How was this tested: Manually using helm template + helm upgrade

  2. Any docs updates needed? No

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.