search

temporalio / helm-charts

Temporal Helm charts
MIT License
294 stars 321 forks source link

Being able to set environment variables using 'envFrom' #397

Open SmaineTF1 opened 1 year ago

SmaineTF1 commented 1 year ago

What was changed

Add the ability to define environment variables that come from configmaps or secrets

Why?

Make use of envFrom is pretty handy when, for instance you have all the environment variables defined in Secrets or Configmaps. That way we only need to have this bit of code if we have all the config env vars in a secret

web:
  additionalEnvSecret: 
    - "temporal-web-envvars"
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

SmaineTF1 commented 10 months ago

What about this PR? Do you need anything else?

sgrzemski commented 9 months ago

+1 to that. @SmaineTF1 could you please fix the semgrep, so that @XaF @underrun or @mindaugasrukas can merge it?

SmaineTF1 commented 9 months ago

@sgrzemski sorry, I'm confused but what should I do for that check? This is not obvious to me :/

sgrzemski commented 9 months ago

@SmaineTF1 :

image

Sorry, I thought it was in a failed state, but it's just queued to be triggerred manually.

SmaineTF1 commented 9 months ago

Should I do something anyway @sgrzemski please?