Open SmaineTF1 opened 1 year ago
What about this PR? Do you need anything else?
+1 to that. @SmaineTF1 could you please fix the semgrep, so that @XaF @underrun or @mindaugasrukas can merge it?
@sgrzemski sorry, I'm confused but what should I do for that check? This is not obvious to me :/
@SmaineTF1 :
Sorry, I thought it was in a failed state, but it's just queued to be triggerred manually.
Should I do something anyway @sgrzemski please?
What was changed
Add the ability to define environment variables that come from configmaps or secrets
Why?
Make use of envFrom is pretty handy when, for instance you have all the environment variables defined in Secrets or Configmaps. That way we only need to have this bit of code if we have all the config env vars in a secret