temporalio / helm-charts

Temporal Helm charts
MIT License
294 stars 321 forks source link

Being able to disable prom annotations #399

Open SmaineTF1 opened 1 year ago

SmaineTF1 commented 1 year ago

What was changed

Default behavior should be to have the annotations disabled at the service level. Note that it is already enabled at the global level by default:

server:
  metrics:
    annotations:
      enabled: true

Why?

That makes easier to configure if you use the prometheus operator for instance

SmaineTF1 commented 10 months ago

Do you need more info?

robholland commented 2 months ago

This is backwards incompatible, you are changing the defaults such that new users would not get the annotations. You aren't considering the top-level setting.