Closed kuzmik closed 2 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thanks for your submission. This fixed has been merged, unfortunately I wasn't able to get it to merge via the PR for some reason.
Thanks for your submission. This fixed has been merged, unfortunately I wasn't able to get it to merge via the PR for some reason.
that's ok with me, as long as it gets fixed. it's not like this was a super complicated PR :D
What was changed
Very simple change: I changed the datatype of
sidecarContainers
to[]
(from{}
).Why?
When running Tanka, we've been getting this warning:
coalesce.go:220: warning: cannot overwrite table with non table for temporal.server.sidecarContainers (map[])
It was rendering the YAML fine, but when CI runs people kept thinking there was an actual issue.