fix: sidecarContainers should be an array, not a dict

temporalio / helm-charts

Temporal Helm charts

MIT License

294 stars 321 forks source link

fix: sidecarContainers should be an array, not a dict #415

Closed kuzmik closed 2 months ago

kuzmik commented 1 year ago

What was changed

Very simple change: I changed the datatype of sidecarContainers to [] (from {}).

Why?

When running Tanka, we've been getting this warning:

coalesce.go:220: warning: cannot overwrite table with non table for temporal.server.sidecarContainers (map[])

It was rendering the YAML fine, but when CI runs people kept thinking there was an actual issue.

CLAassistant commented 1 year ago

All committers have signed the CLA.

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

robholland commented 2 months ago

Thanks for your submission. This fixed has been merged, unfortunately I wasn't able to get it to merge via the PR for some reason.

kuzmik commented 2 months ago

Thanks for your submission. This fixed has been merged, unfortunately I wasn't able to get it to merge via the PR for some reason.

that's ok with me, as long as it gets fixed. it's not like this was a super complicated PR :D