search

temporalio / helm-charts

Temporal Helm charts
MIT License
294 stars 321 forks source link

[Feature Request] Support passing ImagePullSecrets to Temporal Web Deployment Helm Template #419

Closed mustaFAB53 closed 1 month ago

mustaFAB53 commented 11 months ago

Is your feature request related to a problem? Please describe.

Temporal web Kubernetes deployment manifest / helm template do not support passing imagePullSecrets. A support needs to be added for the same as temporal web images can be expected to be fetched from private registries

Describe the solution you'd like

Add required support similar to the one already provided in temporal server deployment manifest

mustaFAB53 commented 11 months ago

Hi Team Any updates here.. I can raise the PR for the same if this feature seems relevant to you

GerardoMoraS commented 3 months ago

Hello guys, I forgot to add a comment here, but I added a PR to implement this feature.

robholland commented 1 month ago

Fix was merged.