temporalio / helm-charts

Temporal Helm charts
MIT License
282 stars 316 forks source link

feat: Add support for `additionalVolumes` and `additionalVolumeMounts` for web #427

Closed joshbranham closed 9 months ago

joshbranham commented 9 months ago

What was changed

Adds the ability to set additionalVolumes and additionalVolumeMounts to the web Deployment.

Why?

This was one of many changes needed to support injecting TLS certificates for full mTLS support. Specifically the web process needs certificates to talk to the backend services when you enable mTLS.

Checklist

  1. Closes

  2. How was this tested:

We have this chart forked internally and are using it. These changes were applied to it and confirmed it deploys successfully and mounts my volumes:

# file: values.yaml
web:
  additionalVolumeMounts:
    - name: certs
      mountPath: /etc/temporal/certs
  additionalVolumes:
    - name: certs
      secret:
        secretName: temporal-certs
  1. Any docs updates needed?
CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.