temporalio / helm-charts

Temporal Helm charts
MIT License
282 stars 316 forks source link

feat: Add ability to set TLS config on `server` components #428

Closed joshbranham closed 9 months ago

joshbranham commented 9 months ago

What was changed

Added a new server.tls configuration in values to allow defining the full TLS configuration found here.

Why?

mTLS support is lacking completely in this chart and requires quiet a bit of changes to get working properly. I have this working locally, but there are a few pieces missing for the whole picture. I am trying to open incremental changes, so please let me know if this is an acceptable approach.

Ideally, we would configure all the TLS settings with environment variables as to not need to update a configmap template in this repo when/if the server config changes. At least with these changes and the other linked PR + some documentation, folks can get mTLS working without having to fork this project.

Checklist

  1. Closes

  2. How was this tested:

    We are using this in our forked internal copy of this chart.

  3. Any docs updates needed?

    We will likely want a doc on configuring mTLS via the chart. However there are many changes needed, so I would suggest saving that for another incremental PR.