temporalio / helm-charts

Temporal Helm charts
MIT License
305 stars 337 forks source link

[Feature Request] Allow `--defaultdb` flag to be passed to schema job #433

Open rikkuness opened 11 months ago

rikkuness commented 11 months ago

Is your feature request related to a problem? Please describe.

When deploying via Helm there appears to be no way to set the --defaultdb flag, other flags have an optional env var but it looks like defaultdb does not https://github.com/temporalio/temporal/blob/main/tools/sql/main.go#L193-L196

Describe the solution you'd like

Either the flag should have an env var setting like other flags eg. SQL_DEFAULTDB or allow passing of arbitrary flags to the command in https://github.com/temporalio/helm-charts/blob/master/templates/server-job.yaml#L90

Additional context