search

temporalio / helm-charts

Temporal Helm charts
MIT License
282 stars 316 forks source link

[Feature Request] sidecar container for schema creation & update jobs #444

Open RonaldGalea opened 7 months ago

RonaldGalea commented 7 months ago

Is your feature request related to a problem? Please describe.

It is currently possible to connect to GCP Cloud SQL via the sidecar proxy - but the schema creation & update jobs do not run this sidecar, meaning one has to manually do it.

Describe the solution you'd like

If the schema jobs ran the sidecar, the process would be streamlined. Is there any reason not to do it that I'm missing?

Thanks.

jsok commented 3 months ago

This is complicated by the fact that the schema setup is done via initContainers, which IIUC run before sideContainers start, i.e. the sql proxy won't be running yet.

Edit: as of Kubernetes 1.28+ this could be solved by allowing the injection of first-class sidecar container, i.e. an initContainer with restartPolicy: Always. This would mean the SQL proxy could start first and contain to run for the lifetime of the main containers in the Pod.