search

temporalio / helm-charts

Temporal Helm charts
MIT License
305 stars 337 forks source link

Set SQL-TLS when sql.tls.enabled is true #456

Closed alexandermarston closed 8 months ago

alexandermarston commented 8 months ago

What was changed

This change adds SQL_TLS as an environment variable to the schema jobs, when you have TLS enabled for your SQL Driver.

Why?

The Schema Jobs are unable to run against a PostgreSQL server that requires TLS, as it does not currently respect your TLS settings.

Checklist

  1. Closes None

  2. How was this tested: Tested on a 1.28 Kubernetes cluster, with an AWS RDS Proxy being used as the PSQL host.

  3. Any docs updates needed? N/A

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Alex Marston seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

syugoman-armenotech commented 8 months ago

it looks like this is a similar PR - https://github.com/temporalio/helm-charts/pull/411

alexandermarston commented 8 months ago

closing in favour of #411