temporalio / helm-charts

Temporal Helm charts
MIT License
282 stars 316 forks source link

[Feature Request] Installing Temporal in Kubernetes with TLS certs in existing secret/configmap. #473

Closed bwgit824 closed 1 month ago

bwgit824 commented 4 months ago

Hello.

I'm installing Temporal in Kubernetes via the helm chart (https://github.com/temporalio/helm-charts/tree/master) and I want to set up TLS. I see the TLS settings here https://github.com/temporalio/helm-charts/blob/master/charts/temporal/values.yaml (server.config.tls). I generate certificates as in this https://github.com/temporalio/samples-server/tree/main/tls/tls-simple example. But I don't understand how to take them from the existing kubernetes secret/configmap. There are additionalVolumes и additionalVolumeMounts in the same values.yaml, but I do not know the correct syntax to add to the installation command. The current .gitlab-ci.yml command is like this:

script:

How can I add an existing secret/configmap here and attach it to a Temporal?

Thanks.

wrbbz commented 4 months ago

Hi! My suggstion to you - use one values.yaml file for all Helm Chart configuration.

In my case, I'm using existing cert files like this:

....
server:
  additionalVolumeMounts:
    - name: temporal-tls
      mountPath: /some/path/for/tls
  additionalVolumes:
    - name: temporal-tls
      secret:
        defaultMode: 420
        secretName: yourTlsSecretName
  config:
    tls:
      frontend:
        server:
          keyFile: /some/path/for/tls/tls.key
          certFile: /some/path/for/tls/tls.cert
        client:
          serverName: SERVERNAME

That should do the trick

robholland commented 1 month ago

This looks like a valid solution to your question, I shall close the issue. Please re-open if this does not solve the issue.