temporalio / helm-charts

Temporal Helm charts
MIT License
276 stars 315 forks source link

Helm git tags don't match with main repo anymore #475

Closed Hades32 closed 2 months ago

Hades32 commented 3 months ago

It seems like you changed from using the Temporal version in your git tags to chart-version tags. So is an issue for us as we automate the DB setup etc too. For that we have one version variable and based on this do clone the main repo, get the SQL tools and apply migrations as well as for selecting the chart.

Are you planning to continue versioning these two independently?

rpomoni commented 3 months ago

Similar issue here: the main tag for this repo is now 1.22.6, but the tag declared in the file values.yam of the helm chart still uses 1.22.4 for server and admintools services.

Launching helm upgrade won't upgrade those 2 services in the cluster.

robholland commented 2 months ago

It is not helm best practise to version the charts based on the application version so we have moved away from that. Following from that git tags will not be made based on Temporal server versions.