Allow to skip database creation

temporalio / helm-charts

Temporal Helm charts

MIT License

276 stars 315 forks source link

Allow to skip database creation #480

Closed VLZZZ closed 3 weeks ago

VLZZZ commented 2 months ago

What was changed

This PR adds an ability to skip database creation. The default values ensures that the change will be backwards compatible with an existing installations.

Why?

Currently it's not possible to use already existing database when deploying Temporal using this Helm chart

Checklist

Closes #440
How was this tested:

I've performed a fresh install with:
```
schema:
createDatabase:
enabled: false
```
Any docs updates needed?

CLAassistant commented 2 months ago

All committers have signed the CLA.

zaenk commented 2 months ago

I just wanted to do this exact same thing! Thanks for opening this PR!

robholland commented 3 weeks ago

Thanks for your contribution :) For future reference: if you make changes to address PR feedback, if you re-request feedback from the relevant person, it makes it more obvious the PR is ready for review again.