temporalio / helm-charts

Temporal Helm charts
MIT License
276 stars 315 forks source link

[Feature Request] Add possibility to add annotations to server configmap #483

Closed ghost closed 2 months ago

ghost commented 2 months ago

Is your feature request related to a problem? Please describe.

I use this helm chart with bank-vault mutating webhook https://bank-vaults.dev/docs/mutating-webhook/.

I want to be able to add annotations to the template server-configmap.yaml in order to be able to mutate some values from vault. (here i want to mutate some dynamic username from vault)

Describe the solution you'd like

In values.yaml maybe add something like server.configAnnotations In server-configmap.yaml add the anotations

Additional context

https://bank-vaults.dev/docs/mutating-webhook/configuration/#secret-and-configmap-examples

conclusion

Is it something you think it may be possible to add?

Thanks you a lot in advance

ghost commented 2 months ago

(may be possible without adding this new annotation) i will try a solution when i have time and submit new issue with pr :)