search

temporalio / helm-charts

Temporal Helm charts
MIT License
276 stars 315 forks source link

adding missing ImagePullSecrets section to web deployment #484

Closed GerardoMoraS closed 4 weeks ago

GerardoMoraS commented 2 months ago

What was changed

There was missing ImagePullSecrets section in Web Deployment please check following ticket.

Why?

Checklist

  1. Closes [Feature Request] Support passing ImagePullSecrets to Temporal Web Deployment Helm Template
  2. How was this tested:

    By adding image pull secrets in development environment and verifying that cluster now pulls images from our private registry.

  3. Any docs updates needed?
CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: robholland
:x: GerardoMoraSalazar
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

robholland commented 4 weeks ago

Please sign the CLA.