search

temporalio / helm-charts

Temporal Helm charts
MIT License
305 stars 335 forks source link

Update Cassandra host URLs to remove the ".cluster.local" suffix #485

Closed cege7480 closed 3 months ago

cege7480 commented 5 months ago

What was changed

No longer hardcoding the cluster.local suffix on various service reference entries.

Why?

Hardcoding breaks when the cluster name isn't cluster.local. Relative path will work unless you've done something super weird with your dns.

Checklist

  1. Closes #469

  2. How was this tested: Ran the helm chart... installed. Boom.
    Successfully able to resolve using relative domain names.

  3. Any docs updates needed? Nah.

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

cege7480 commented 3 months ago

Please remove the devcontainer and dependabot files, they are not related to this change.

Sorry about that.

robholland commented 3 months ago

Thanks for your contribution :)