search

temporalio / helm-charts

Temporal Helm charts
MIT License
276 stars 315 forks source link

Ensure appVersion is used by default as the server image tag. #488

Closed ktulsyan closed 1 month ago

ktulsyan commented 1 month ago

What was changed

Updated image versions for frontend/matching/worker/history/admintools to 1.23.1

Why?

Chart.yaml and values.yaml were out of sync

Checklist

  1. How was this tested: Not tested

  2. Any docs updates needed?

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

robholland commented 1 month ago

Thank you for contributing :)

Our systems bump the appVersion in the Chart.yaml but we missed that our templates didn't use that value. Please use templating in the server templates, and replace the tags in the values file with empty ones.

Some more context/suggestions here: https://stackoverflow.com/questions/58065225/image-tag-in-values-yaml-vs-appversion-in-chart-yaml.

Please let me know if that's not clear, you can find me on public Slack if that's easiest.