temporalio / helm-charts

Temporal Helm charts
MIT License
276 stars 315 forks source link

Fix default image tag type in values #489

Closed Blamas closed 1 month ago

Blamas commented 1 month ago

What was changed

Fix the default type of the image tag from map {} to string "" in the values file. Issue introduced in https://github.com/temporalio/helm-charts/pull/488

Why?

It's causing these errors when rendering the chart

coalesce.go:286: warning: cannot overwrite table with non table for temporal.temporal.server.image.tag (map[])

Checklist

  1. Closes None

  2. How was this tested: By rendering helm templates locally

  3. Any docs updates needed? No

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

robholland commented 1 month ago

Thanks :)