Closed vogre closed 3 weeks ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
I know we already do this, and I'm happy to merge, but could you please explain what the use case is here so I can learn?
@robholland - we use it roughly like this:
e.g. by helm template --set foo=bar -f values_web.yaml
,
and values_web.yaml
of
web:
service:
annotations:
url: https://{{ $.Values.foo }}-temporal.example.com
We would utilize the templating features of helm, inside the values.yaml
file (usually the templating only works in the templates/
directory.
Since this behavior is actually surprising - we could also set the value directly by
helm template --set 'web.service.annotations.url=https://bar-temporal.example.com'
Although it's a nice feature to allow extensibility of the template.
What was changed
Use templating for
web.service
annotations in the same way asserver.service
is defined https://github.com/temporalio/helm-charts/blob/bad8c74311717f2121579f64e2e6b1670fc19818/charts/temporal/templates/server-service.yaml#L15.Why?
A very cool trick to allow passing templated values inside the values.yaml file instead of relying on an outside templating engine
Checklist
Closes
How was this tested: Added a template in
values.yaml
and ranhelm template
.Any docs updates needed? No