temporalio / helm-charts

Temporal Helm charts
MIT License
305 stars 335 forks source link

Fix: Quote ES credentials #505

Closed VLZZZ closed 3 months ago

VLZZZ commented 3 months ago

What was changed

Elasticsearch plaintext credentials are now escaped to respect password which contains special characters

Why?

Without this change it's impossible to use password with specials characters which might be obligatory for some 3rd party managed Elasticsearch solutions.
E.g. - When using AWS Opensearch you're obliged to use special symbols if using master password istead of IAM auth.

Checklist

  1. Closes #504

  2. How was this tested: We're using custom fork with this change already.

  3. Any docs updates needed? No