search

temporalio / helm-charts

Temporal Helm charts
MIT License
275 stars 315 forks source link

[Feature Request] Remove dependencies on monitoring tools #518

Open BrianKopp opened 2 days ago

BrianKopp commented 2 days ago

Is your feature request related to a problem? Please describe.

Monitoring tools shouldn't be specified by this application.

Describe the solution you'd like

Remove dependencies on monitoring tools.

robholland commented 2 days ago

I would add that we should continue to add Prometheus annotations though if prometheus.enable is true. Or, maybe a new value with a more intent-revealing name that toggles the annotations.

BrianKopp commented 1 day ago

Ok sounds good. I'll split these up into two different PRs, the first for grafana, the second for prometheus. The grafana removal is much more straightforward. There are some different choices that could be made on the prometheus side of things for implementing scrape config (labels, servicemonitors, etc.), as well as where to draw the line for what stays in.