search

temporalio / helm-charts

Temporal Helm charts
MIT License
276 stars 315 forks source link

[Issue 523] Fix logic for createDatabase.enabled variable #524

Closed ogusak closed 2 days ago

ogusak commented 3 days ago

What was changed

Fixed logic flow for .Values.schema.createDatabase.enabled to allow creating databases if they are not provisioned beforehand.

Why?

See bug described in https://github.com/temporalio/helm-charts/issues/523

Checklist

  1. Closes 523

  2. How was this tested: helm template . -f values/values.postgresql.yaml --debug > test.yaml and inspecting content of the resulting manifest. Tested for

    • .Values.schema.createDatabase.enabled=true
    • .Values.schema.createDatabase.enabled=false

  3. Any docs updates needed? N/A

CLAassistant commented 3 days ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 3 days ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

robholland commented 3 days ago

Should be fixed by #522, please test this and let me know.

robholland commented 2 days ago

Please let me know if #522 does not fix this for you, I'll re-open.

ogusak commented 2 days ago

Tested just now and can see create-default-store and create-visibility-store init containers are rendered. Thank you @robholland !