search

temporalio / helm-charts

Temporal Helm charts
MIT License
294 stars 321 forks source link

Remove grafana dependency #526

Open BrianKopp opened 1 month ago

BrianKopp commented 1 month ago

What was changed

Removed Grafana dependency and related config.

Why?

Configuration & installation of monitoring tools is a cluster-level consideration, and shouldn't be specified in an application such as this.

Checklist

  1. Closes #518

  2. How was this tested: Diff between helm template main and this branch has no differences.

Note - if running helm from the directory or source, and if you don't run helm dependencies update, then helm will want to install grafana since it's enabled by default.

  1. Any docs updates needed?

    README is updated.

This will be a breaking change for folks who have grafana enabled, since it will delete their temporal-installed-grafana.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Brian Kopp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.