temporalio / helm-charts

Temporal Helm charts
MIT License
294 stars 321 forks source link

[Feature Request] Remove Prometheus dependency #527

Open BrianKopp opened 1 month ago

BrianKopp commented 1 month ago

Is your feature request related to a problem? Please describe.

Monitoring tools shouldn't be specified by this application.

Describe the solution you'd like

Remove dependencies on monitoring tools.

Additional context

We'll want to remove the dependency on the prometheus helm chart, but still provide a reasonable way to enable prometheus metric scraping. This will be accomplished via the conditional ServiceMonitor.

The hard-coded labels that were in this chart beforehand (prometheus.io/*) aren't necessary if we are providing a ServiceMonitor as a standard way for discovering targets. They should be removed.