Use admintools-env and secret for ES password consistent with e.g. jobs

temporalio / helm-charts

Temporal Helm charts

MIT License

294 stars 321 forks source link

Use admintools-env and secret for ES password consistent with e.g. jobs #530

Open csabatuz-chess opened 1 month ago

csabatuz-chess commented 1 month ago

What was changed

The ES check init container on the main deployment of temporal server is made consistent with the Job templates' similar containers.

Why?

Problem encountered with setting up Temporal deployment with external Elasticsearch using authentication. Issue created: https://github.com/temporalio/helm-charts/issues/529

Why draft

We need to work a bit to test this chart version with our deployment

CLAassistant commented 1 month ago

All committers have signed the CLA.

CLAassistant commented 1 month ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

robholland commented 1 month ago

We can test this also, the change looks roughly right to me, feel free to mark this PR as ready for review.