[Bug] `helm upgrade` does not work if `schema.enabled` is true

temporalio / helm-charts

Temporal Helm charts

MIT License

312 stars 342 forks source link

[Bug] `helm upgrade` does not work if `schema.enabled` is true #554

Open kosmoz opened 1 month ago

kosmoz commented 1 month ago

What are you really trying to do?

Running helm upgrade on an existing release of the temporal chart.

Describe the bug

Schema migrations are performed in a Job, but the resource is never garbage collected. When trying to upgrade the release, helm fails because the Job resource has immutable fields.

Minimal Reproduction

Install helm chart
Try to upgrade helm release

Environment/Versions

Temporal Version: helm chart 0.45.0

Additional context

kosmoz commented 1 month ago

Can be fixed by setting the ttlSecondsAfterFinished on the Job. I will create a PR shortly.

FurqanHabibi commented 1 month ago

Another alternative is to specify the job as a pre-install hook. Will create a PR with this approach.

robholland commented 1 month ago

Please give https://github.com/temporalio/helm-charts/pull/564 a try.