search

temporalio / roadrunner-temporal

Temporal PHP-SDK Host Process plugin for Roadrunner
MIT License
22 stars 8 forks source link

[💡 FEATURE REQUEST]: Support FailureConverter API #277

Closed Quinn-With-Two-Ns closed 1 year ago

Quinn-With-Two-Ns commented 2 years ago

Plugin

No response

I have an idea!

The error conversion API has been refactored to expose a customization point for users to control how errors are serialized/deserialized. Should start using and add support for this new API.

See also: https://github.com/temporalio/sdk-go/pull/924 https://github.com/temporalio/sdk-typescript/pull/887 https://github.com/temporalio/api/blob/master/temporal/api/failure/v1/message.proto#L81

cretz commented 2 years ago

Note that at the least, internalbindings.ConvertErrorToFailure and internalbindings.ConvertFailureToError is going away next version and you'll have to call temporal.GetDefaultFailureConverter().ErrorToFailure and temporal.GetDefaultFailureConverter().FailureToError respectively to get today's behavior.

rustatian commented 2 years ago

Hey @cretz @Quinn-With-Two-Ns 👋🏻 Nice, thanks for noting; we'll plan this for the RoadRunner v2.12.0.