temporalio / roadrunner-temporal

Temporal PHP-SDK Host Process plugin for Roadrunner

MIT License

22 stars 8 forks source link

feature: interceptors plugins support #322

Closed cv65kr closed 1 year ago

cv65kr commented 1 year ago

Reason for This PR

https://github.com/roadrunner-server/roadrunner/issues/1313

Description of Changes

Possibility to use custom interceptors for Temporal.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.] [Reviewer TODO: Verify that these criteria are met. Request changes if not]

[x] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[x] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[x] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

rustatian commented 1 year ago

Hey @cv65kr 👋🏻

It would be nice to have tests for the new temporal interceptors. You may write a dummy plugin-interceptor as I wrote in many places in the rr-e2e-test (e.g: link) and do some processing in it and then check the output.

cv65kr commented 1 year ago

@rustatian code improvements are done. Will write some test soon.

codecov-commenter commented 1 year ago

Codecov Report

Merging #322 (7d6f210) into master (75b8acb) will decrease coverage by 0.03%. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##           master    #322      +/-   ##
=========================================
- Coverage    3.71%   3.68%   -0.03%     
=========================================
  Files          19      19              
  Lines        1644    1657      +13     
=========================================
  Hits           61      61              
- Misses       1581    1594      +13     
  Partials        2       2

Impacted Files	Coverage Δ
aggregatedpool/workers.go	`0.00% <0.00%> (ø)`
plugin.go	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rustatian commented 1 year ago

Thanks @cv65kr 👍🏻