temporalio / samples-java

Temporal Java SDK samples
http://docs.temporal.io/docs/java-quick-start
Other
162 stars 141 forks source link

[Feature Request] Default constructor on an input parameter 'Money transfer project' #635

Open GeethaAnne opened 3 months ago

GeethaAnne commented 3 months ago

Is your feature request related to a problem? Please describe.

Customer Miro reported below: 'I started writing a basic "mocked up" data migration based on the "Money transfer project" and the Java SDK documentation.   Its been going slowly since I got stuck on the problem below, unfortunately. The problem I hit was related to serialization/deserialization and is lightly documented (and not included in any of the examples).  This is as simple as forgetting to create a default constructor on say an input parameter.  If this happens the test just hangs forever.'

Describe the solution you'd like

Create a default constructor on an input parameter

Additional context

cretz commented 3 months ago

Create a default constructor on an input parameter

Unless I'm misunderstanding the request, the SDK cannot just create default constructors on user-provided classes. Which class are you wanting a default constructor added on to? The money transfer project in this repository doesn't use separate input classes. I think this is a case of just making sure the serialization constraints are well documented.