search

temporalio / samples-server

MIT License
37 stars 32 forks source link

Use ENTRYPOINT instead of CMD to run promqltodd #61

Closed taonic closed 11 months ago

taonic commented 11 months ago

What was changed

Use ENTRYPOINT to replace CMD in promql-to-dd-go Dockerfile.

Why?

Requested at: https://github.com/temporalio/samples-server/issues/60

This is to add convenience to run the image as a binary by supplying flags directly without specifying the executable.

Checklist

  1. Closes https://github.com/temporalio/samples-server/issues/60
  2. How was this tested: Manually..